Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users if they copied the example configurations from the README #62

Open
artsiom-streetshares opened this issue Apr 22, 2022 · 3 comments

Comments

@artsiom-streetshares
Copy link

artsiom-streetshares commented Apr 22, 2022

Hi there. Thanks for the useful plugin.

Though I noticed it doesn't work as I expect in the visual mode. If I press ve it still selects word as usual. This is my config

let g:wordmotion_nomap = 1
nmap w          <Plug>WordMotion_w
nmap b          <Plug>WordMotion_b
nmap gE         <Plug>WordMotion_gE
omap aW         <Plug>WordMotion_aW
cmap <C-R><C-W> <Plug>WordMotion_<C-R><C-W>

Could you guide me on how to resolve that? Thanks!

@chaoren
Copy link
Owner

chaoren commented Apr 23, 2022

I think you misunderstood the configuration options. let g:wordmotion_nomap = 1 disables the default mappings. You can remove all of that configuration and the plugin should just work.

@chaoren chaoren closed this as completed Apr 23, 2022
@chaoren chaoren reopened this Apr 23, 2022
@chaoren
Copy link
Owner

chaoren commented Apr 23, 2022

I've removed all of the example configurations. The text descriptions should be good enough for anyone who actually wants them. Most users should just want the default mappings and do not actually need any configuration. I'll try to detect if the user copied the configurations exactly as-is from the README and warn them about it. I might as well also warn them if they still have the obsolete cw and dw mappings that were recommended ages ago.

@chaoren chaoren changed the title e in visual mode Warn users when they blindly copy the example configurations Apr 23, 2022
chaoren added a commit that referenced this issue Apr 23, 2022
They were more confusing than helpful.
chaoren added a commit that referenced this issue Apr 23, 2022
They were more confusing than helpful.
chaoren added a commit that referenced this issue Apr 23, 2022
They were more confusing than helpful.
chaoren added a commit that referenced this issue Apr 23, 2022
They were more confusing than helpful.
@chaoren chaoren changed the title Warn users when they blindly copy the example configurations Warn users if they copied the example configurations from the README Apr 23, 2022
@artsiom-streetshares
Copy link
Author

@chaoren heey, thank you so much! yeah, I don't know why decided the config is required, works great out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants