Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make byteman plugins runnable on jdk8 #202

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Make byteman plugins runnable on jdk8 #202

merged 2 commits into from
Aug 15, 2022

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Aug 13, 2022

Signed-off-by: Cwen Yin [email protected].

Update byteman-helper version to v4.0.18-0.10, in this version, we make byteman plugins runnable on idk8

chaos-mesh/byteman-helper#15

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • STRRL
  • WangXiangUSTC

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@cwen0 cwen0 changed the title Make byteman runnable on jdk8 Make byteman plugins runnable on jdk8 Aug 13, 2022
WangXiangUSTC
WangXiangUSTC approved these changes Aug 13, 2022
View reviewed changes
Copy link
Collaborator

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member Author

cwen0 commented Aug 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@cwen0: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@STRRL
Copy link
Member

STRRL commented Aug 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 91044db

@ti-chi-bot ti-chi-bot merged commit e771b9d into chaos-mesh:main Aug 15, 2022
@cwen0 cwen0 deleted the update-byteman branch August 15, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRRL STRRL STRRL approved these changes

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cwen0 @ti-chi-bot @STRRL @WangXiangUSTC