Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue about disk attack cannot work well in chaos-mesh:physical machine chaos #236

Merged
merged 27 commits into from
Feb 8, 2023
Merged

Fix issue about disk attack cannot work well in chaos-mesh:physical machine chaos #236

merged 27 commits into from
Feb 8, 2023

Conversation

Andrewmatilde
Copy link
Member

Add a command pool to orgnize sub commands.
Make disk chaos in server side runs asynchronously.

@Andrewmatilde
add default value of PayloadProcessNum&FillByFAllocate
4b776ab 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
recover unit-test
03bc706 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
recover unit-test
31a7dc4 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
Enable fill | write in dir.
971d0c9 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
Enable fill | write in dir.
c7c3750 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
Merge branch 'chaos-mesh:main' into main
7633de7
@Andrewmatilde
Enable fill | write in dir.
0eed6bf 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
fix lint
5c2e6d9 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
Merge branch 'main' into main
3e1430c
@Andrewmatilde
fix log
66af8e6 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
Merge remote-tracking branch 'origin/main' into main
e956a32
@Andrewmatilde
Merge remote-tracking branch 'm/main' into main
1447500
@Andrewmatilde
Merge remote-tracking branch 'm/main' into main
0594fa5
@Andrewmatilde
Merge remote-tracking branch 'main/main' into main
10f2fb4
@Andrewmatilde
ignore some unhandled errors & fix unexported returned value in expor…
f70a0f5 
…ted function

Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
fix deprecated function
5bafaf3 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
complete async disk attack in server side
9c9ace0 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
better input args type in command pool
0ab6238 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
complete test for command pool
c0e3d3c 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
add license
083ca2b 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
add license
c5f2b39 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
fix comment
890ae6d 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
add output channel to pools
cc151c6 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
manually test & fix disk attack
baa5f04 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
fix ut in disk attack
ba2da52 
Signed-off-by: andrewmatilde <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 8, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Andrewmatilde
fix Boilerplate header
a600896 
Signed-off-by: andrewmatilde <[email protected]>
@Andrewmatilde
Copy link
Member Author

PTAL @cwen0 .

cwen0
cwen0 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andrewmatilde
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@Andrewmatilde: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Andrewmatilde
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 43c4711

@Andrewmatilde Andrewmatilde merged commit 19a1572 into chaos-mesh:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwen0 cwen0 cwen0 approved these changes

@Gallardot Gallardot Awaiting requested review from Gallardot

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
require-LGT1 size/XXL status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andrewmatilde @ti-chi-bot @cwen0