Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix on release action #78

Merged
merged 2 commits into from
Jun 30, 2021
Merged

minor fix on release action #78

merged 2 commits into from
Jun 30, 2021

Conversation

WangXiangUSTC
Copy link
Collaborator

@WangXiangUSTC WangXiangUSTC commented Jun 28, 2021

Signed-off-by: xiang [email protected]

  1. download v1.0.0, and execute chaosd version, output:
Chaosd Version: version.Info{GitVersion:"v0.0.0-master+$Format:%h$", GitCommit:"$Format:%H$", BuildDate:"2021-06-22T02:31:24Z", GoVersion:"go1.16.2", Compiler:"gc", Platform:"linux/amd64"}

you can see the GitVersion and GitCommit are wrong. It is because that the ci environment lack git.

  1. the tools lack PortOccupyTool, so can't execute network attack with port occupy.

Signed-off-by: xiang <[email protected]>
@WangXiangUSTC
Copy link
Collaborator Author

@cwen0 @Andrewmatilde PTAL

Signed-off-by: xiang <[email protected]>
Copy link
Member

@Andrewmatilde Andrewmatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jun 30, 2021

/merge

@cwen0 cwen0 merged commit a1c4108 into chaos-mesh:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants