network attack: support bandwidth limit #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
YangKeao
reviewed
Nov 3, 2021
|
|
||
| cmd.Flags().StringVarP(&options.Rate, "rate", "r", "", "the speed knob, allows bps, kbps, mbps, gbps, tbps unit. bps means bytes per second") | ||
| cmd.Flags().Uint32VarP(&options.Limit, "limit", "l", 0, "the number of bytes that can be queued waiting for tokens to become available") | ||
| cmd.Flags().Uint32VarP(&options.Buffer, "buffer", "b", 0, "the maximum amount of bytes that tokens can be available for instantaneously") |
There was a problem hiding this comment.
I have a little concern. Some of these parameters are required (like the rate, buffer and limit). Should we give them a better default value (but I cannot tell a reasonable value), or validate the input?
The user may run chaosd only with rate, and the command will succeed and give back a uid. However, it fails in the chaos-daemon (but the error doesn't return out, this bug has been fixed in the latest chaos-daemon).
There was a problem hiding this comment.
Yeah, I will add default values for them, and validate the value.
There was a problem hiding this comment.
done, PTAL again
3 tasks
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close issue #89