Fix vof mass monitoring print #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaisb
approved these changes
Mar 13, 2024
|
You will need to rebase @AmishgaAlphonius then I can merge! |
AmishgaAlphonius
force-pushed
the
fix-vof-mass-monitoring-print
branch
from
cb36588
to
7df54c0
Compare
Done ! :) |
oguevremont
approved these changes
Mar 14, 2024
Comment on lines
+78
to
+79
| * @brief Generate a table from a vector of scalars (independent variable) and | ||
| * a vector of vectors of scalars (dependent variables). |
There was a problem hiding this comment.
Suggested change
| * @brief Generate a table from a vector of scalars (independent variable) and | |
| * a vector of vectors of scalars (dependent variables). | |
| * @brief Generate a table from a vector of scalars (independent variable) and | |
| * a vector of vectors (dependent variables). |
Comment on lines
+88
to
+89
| * @param[in] dependent_vector Vector of vectors of scalar values containing | ||
| * dependant variables values. |
There was a problem hiding this comment.
Suggested change
| * @param[in] dependent_vector Vector of vectors of scalar values containing | |
| * dependant variables values. | |
| * @param[in] dependent_vector Vector of vectors values containing | |
| * dependant variables values. |
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem When calculate mass conservation in the post-processing was enabled (default) and the verbosity was set to verbose, the mass conservation table was displayed on terminal at the end of the simulation. If a lot of time iterations were made, this could cover a significant chunk of the terminal window and might not be pertinent to have it their when .dat files is also outputted by the simulation. Description of the solution In a similar way to "VOF Barycenter", the output of the "VOF Mass Conservation" is now displayed at every time iteration on the terminal. How Has This Been Tested? Expected tests have been updated output : applications_tests/lethe-fluid/gls_vof_1_isothermal_compressible_fluid.output applications_tests/lethe-fluid/gls_vof_2_isothermal_compressible_fluids.output applications_tests/lethe-fluid/gls_vof_dirichlet_boundary_condition.output applications_tests/lethe-fluid/gls_vof_periodic_boundary_condition.output applications_tests/lethe-fluid/time_dependent_boundaries_vof.output Mass monitoring has been added to the following test to improve robustness: applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm (.output) Future changes Change all set_precision in the make_table functions to set_scientific as default. Comments A new make_table_scalars_vectors function has been added in utilities.h/.cc. A new boolean argument in make_table functions has been added, namely display_scientific_notation to decide if the display of table values is displayed at a fixed decimal or in scientific notation. Former-commit-id: 82095ba
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem When calculate mass conservation in the post-processing was enabled (default) and the verbosity was set to verbose, the mass conservation table was displayed on terminal at the end of the simulation. If a lot of time iterations were made, this could cover a significant chunk of the terminal window and might not be pertinent to have it their when .dat files is also outputted by the simulation. Description of the solution In a similar way to "VOF Barycenter", the output of the "VOF Mass Conservation" is now displayed at every time iteration on the terminal. How Has This Been Tested? Expected tests have been updated output : applications_tests/lethe-fluid/gls_vof_1_isothermal_compressible_fluid.output applications_tests/lethe-fluid/gls_vof_2_isothermal_compressible_fluids.output applications_tests/lethe-fluid/gls_vof_dirichlet_boundary_condition.output applications_tests/lethe-fluid/gls_vof_periodic_boundary_condition.output applications_tests/lethe-fluid/time_dependent_boundaries_vof.output Mass monitoring has been added to the following test to improve robustness: applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm (.output) Future changes Change all set_precision in the make_table functions to set_scientific as default. Comments A new make_table_scalars_vectors function has been added in utilities.h/.cc. A new boolean argument in make_table functions has been added, namely display_scientific_notation to decide if the display of table values is displayed at a fixed decimal or in scientific notation. Former-commit-id: 82095ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
calculate mass conservationin thepost-processingwas enabled (default) and theverbositywas set toverbose, the mass conservation table was displayed on terminal at the end of the simulation. If a lot of time iterations were made, this could cover a significant chunk of the terminal window and might not be pertinent to have it their when.datfiles is also outputted by the simulation.Description of the solution
How Has This Been Tested?
Expected tests have been updated output :
applications_tests/lethe-fluid/gls_vof_1_isothermal_compressible_fluid.outputapplications_tests/lethe-fluid/gls_vof_2_isothermal_compressible_fluids.outputapplications_tests/lethe-fluid/gls_vof_dirichlet_boundary_condition.outputapplications_tests/lethe-fluid/gls_vof_periodic_boundary_condition.outputapplications_tests/lethe-fluid/time_dependent_boundaries_vof.outputMass monitoring has been added to the following test to improve robustness:
applications_tests/lethe-fluid/heat_transfer_vof_phase_change_constrain_solid_domain.prm(.output)Future changes
set_precisionin themake_tablefunctions toset_scientificas default.Comments
make_table_scalars_vectorsfunction has been added in utilities.h/.cc.make_tablefunctions has been added, namelydisplay_scientific_notationto decide if the display of table values is displayed at a fixed decimal or in scientific notation.