Inlet Dirichlet boundary condition for tracer #1284
+510
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguevremont
force-pushed
the
neumann_bc_tracer
branch
from
efc300a
to
db82db2
Compare
oguevremont
added
Enhancement
lpsaavedra
requested changes
Sep 19, 2024
| subsection fluid dynamics | ||
| set verbosity = quiet | ||
| set tolerance = 1e-12 | ||
| set max iterations = 10 |
There was a problem hiding this comment.
I think you can remove this parameter since it uses the default value
|
|
||
| * ``type``: This is the type of boundary condition being imposed. | ||
| * ``dirichlet``, to impose a given tracer value at the boundary, | ||
| * ``inlet dirichlet``, to impose the Dirichlet boundary condition weakly using a Neumann approach. |
There was a problem hiding this comment.
I wonder if inlet weak dirichlet would be more appropriate. Since in theory you can set a dirichlet one at the inlet as well...
| @@ -691,8 +692,9 @@ namespace BoundaryConditions | |||
| class TracerBoundaryConditions : public BoundaryConditions<dim> | |||
| { | |||
| public: | |||
| std::vector<std::shared_ptr<Functions::ParsedFunction<dim>>> tracer; | |||
| std::vector<std::shared_ptr<Functions::ParsedFunction<dim>>> dirichlet; | |||
There was a problem hiding this comment.
Maybe it would be better to name this as:
Suggested change
| std::vector<std::shared_ptr<Functions::ParsedFunction<dim>>> dirichlet; | |
| std::vector<std::shared_ptr<Functions::ParsedFunction<dim>>> dirichlet_functions; |
| @@ -33,6 +35,10 @@ template <int dim> | |||
| class TracerAssemblerBase | |||
| { | |||
| public: | |||
| TracerAssemblerBase(std::shared_ptr<SimulationControl> p_simulation_control) | |||
There was a problem hiding this comment.
This new parameter needs to be added to the brief of the function and shouldn't it be a const ref? I think it could be a const ref in all the assemblers
| @@ -143,4 +154,51 @@ class TracerAssemblerBDF : public TracerAssemblerBase<dim> | |||
| }; | |||
|
|
|||
|
|
|||
| /** | |||
| * @brief Class that assembles the inlet dirichlet boundary condition for the tracer solver. | |||
There was a problem hiding this comment.
Suggested change
| * @brief Class that assembles the inlet dirichlet boundary condition for the tracer solver. | |
| * @brief Class that assembles weakly the inlet dirichlet boundary condition for the tracer solver. |
Comment on lines
+162
to
+165
| * @param simulation_control Shared pointer of the SimulationControl object | ||
| * controlling the current simulation | ||
| * @param p_boundary_conditions_tracer TracerBoundaryConditions object that hold | ||
| * boundary condition information for the Tracer solver |
There was a problem hiding this comment.
Add to the parameter brief [in], [out] or [in,out]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some simulations, imposing Dirichlet conditions made the linear systems too stiff. We can now impose weakly boundary conditions at inlets using the velocity times Dirichlet value as a flux, in a Neumann approach.
Testing
An application test is added.
Documentation
The new type of boundary condition is added to the documentation.
Miscellaneous (will be removed when merged)
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: