Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug in the VOF auxiliary physics was discovered when rerunning the gravity wave example. In the PR #994, BDF extrapolation of the velocity vector field in the VOF auxiliary physic was moved to the scratch data. However, the implementation was bypassed by an "if" condition.
Solution
This bug is fixed with this PR, and an application test was added to ensure that the feature remains intact with future implementations.
Testing
The new application test:
applications_tests/lethe-fluid/vof-velocity-extrapolation.prm
Miscellaneous (will be removed when merged)
A deal.ii version dependency when using kelly mesh refinement on the phase fraction with the BDF velocity extrapolation in VOF has been noticed, an issue will be opened to investigate this further.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: