-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented igraph #1196
base: master
Are you sure you want to change the base?
Implemented igraph #1196
Conversation
If it helps generalize the PR, I believe the same |
Thanks very much. To merge this PR, we'll need to fix F2C_EXTERNAL_ARITH_HEADER so it doesn't contain user-specific paths. Maybe this can be done by patching the package's build script to set the variable, rather than setting it in meta.yaml. We'll also need a test script to verify that the package works. Please do the following:
|
@@ -617,7 +617,8 @@ def env_vars(self): | |||
}) | |||
|
|||
for var in self.meta["build"]["script_env"]: | |||
key, value = var.split("=") | |||
key, value = var.split("=",1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was failing because of finding
IGRAPH_CMAKE_EXTRA_ARGS=-DF2C_EXTERNAL_ARITH_HEADER=../../../../../../../android64_x86_64_arm64.h -DIEEE754_DOUBLE_ENDIANNESS_MATCHES=ON
Multiple "=", now will only take the first segment as key and the rest as value as is
tested in Python 3.11, and ABIs:
Tested on ubuntu with pixel 4 API 31 emulator x86_64 By tested i mean i have a script the uses all that packages, and is working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-igraph 0.11.6 is out now, you could consider packaging that version instead.
build: | ||
number: 0 | ||
script_env: | ||
# paralelize compilation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# paralelize compilation | |
# parallelize compilation |
It need to use ENV
IGRAPH_CMAKE_EXTRA_ARGS='-DF2C_EXTERNAL_ARITH_HEADER=/home/cbernal/Downloads/android64_x86_64_arm64.h -DIEEE754_DOUBLE_ENDIANNESS_MATCHES=ON'
During the execution of build-wheel.py
And needs to use api-level 24
IGRAPH_CMAKE_EXTRA_ARGS='-DF2C_EXTERNAL_ARITH_HEADER=/home/cbernal/Downloads/android64_x86_64_arm64.h -DIEEE754_DOUBLE_ENDIANNESS_MATCHES=ON' ./build-wheel.py -v --api-level 24 --python 3.11 --abi arm64-v8a igraph