Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial minor updates to fix a bug in unit test code, and allow specification of non-default test image in BaseApiTester. #8

Merged
merged 2 commits into from
Mar 12, 2013

Conversation

tausten
Copy link

@tausten tausten commented Mar 11, 2013

Hi Charles,

I wanted to thank you for putting this up on here. I was starting down the same path when I stumbled on your project and saw that you've already bundled things up nicely.

This initial pull request contains a couple of minor updates to get a failing test going, and to allow specification of an alternate test image on the BaseApiTester commandline... but more importantly it allows me to say hello.

Once I get my bearings I may be able to help with one or more of the larger tasks you'd identified in the readme. In the meantime, I'll send pull requests from time to time with minor updates that accumulate as I'm working my way through.

Thanks again,

Tyler

Tyler Austen added 2 commits March 8, 2013 16:57
The test file is "phototest.tif", and now that this is fixed, the
expected text must be provided to make the assertion pass.
If an argument is specified, it will now be used as the path to the test
image.
charlesw added a commit that referenced this pull request Mar 12, 2013
Initial minor updates to fix a bug in unit test code, and allow specification of non-default test image in BaseApiTester.
@charlesw charlesw merged commit 826d2ab into charlesw:master Mar 12, 2013
@charlesw
Copy link
Owner

Thanks Tyler your changes are most welcome.

@CoderNbrSix
Copy link

Hi Charles

I also want to thank you. I was attempting to add a C++ .NET wrapper but
quickly found I have a lot to learn about Microsoft's PC system
programming. What you have here covers all the details I was getting hung
up on. After a day of playing with the BaseApiTester I was able to quickly
setup a VB 2012 test program to use the NET4.5 dll. Very Sweet.

I am looking to get at the Font information but so far do not see how. I
will add it to you wrapper and then review the GitHub procedures for a
Branch to make my changes available.
Thank You
Walter
On Mon, Mar 11, 2013 at 11:32 AM, Tyler Austen [email protected]:

Hi Charles,

I wanted to thank you for putting this up on here. I was starting down the
same path when I stumbled on your project and saw that you've already
bundled things up nicely.

This initial pull request contains a couple of minor updates to get a
failing test going, and to allow specification of an alternate test image
on the BaseApiTester commandline... but more importantly it allows me to
say hello.

Once I get my bearings I may be able to help with one or more of the
larger tasks you'd identified in the readme. In the meantime, I'll send
pull requests from time to time with minor updates that accumulate as I'm
working my way through.

Thanks again,

Tyler

You can merge this Pull Request by running

git pull https://github.com/tausten/tesseract master

Or view, comment on, or merge it at:

#8
Commit Summary

  • Fixing typo and missing expected text in test.
  • Allow alternate test image in BaseApiTester.

File Changes

Patch Links:

@charlesw
Copy link
Owner

Hi Walter,
Glad you enjoyed my work!

Yes I missed the font information, and have created task #9 with some details on how to get started if you choose to add this. If you do please just leave a comment in the task that your having a look into adding this. Feel free to ask any questions and I'll do my best to answer them.

Regards,
Charles

@CoderNbrSix
Copy link

Hi Charles
Will also review (learn) GitHub and provide the comment.
Thanks again
Walter

On Wed, Mar 13, 2013 at 5:04 AM, Charles Weld [email protected]:

Hi Walter,
Glad you enjoyed my work!

Yes I missed the font information, and have created task #9https://github.com/charlesw/tesseract/issues/9with some details on how to get started if you choose to add this. If you
do please just leave a comment in the task that your having a look into
adding this. Feel free to ask any questions and I'll do my best to answer
them.

Regards,
Charles


Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-14830775
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants