Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): ShowOutput flag displays in realtime #405

Merged
merged 2 commits into from
Nov 29, 2023
Merged

(fix): ShowOutput flag displays in realtime #405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d66af4f
(fix): ShowOutput flag works as intended
hopefulTex Aug 1, 2023
2a84b71
Update command.go
hopefulTex Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion spin/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func (o Options) Run() error {
title: o.TitleStyle.ToLipgloss().Render(o.Title),
command: o.Command,
align: o.Align,
showOutput: o.ShowOutput && isTTY,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing in v0.11. It prevents from using spin command :(

timeout: o.Timeout,
hasTimeout: o.Timeout > 0,
}
Expand All @@ -46,7 +47,9 @@ func (o Options) Run() error {
}

if o.ShowOutput {
if isTTY {
// BubbleTea writes the View() to stderr.
// If the program is being piped then put the accumulated output in stdout.
if !isTTY {
_, err := os.Stdout.WriteString(m.stdout)
if err != nil {
return fmt.Errorf("failed to write to stdout: %w", err)
Expand Down
Loading