(v2) feat!: make transform an interface type #417
+35
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
v2-transform
branch
3 times, most recently
from
49011fc
to
ab090b0
Compare
aymanbagabas
changed the title
aymanbagabas
force-pushed
the
v2-transform
branch
from
ab090b0
to
b26a4d9
Compare
caarlos0
reviewed
Oct 30, 2024
caarlos0
approved these changes
Oct 30, 2024
aymanbagabas
force-pushed
the
v2-transform
branch
from
9ff47a9
to
1b669f5
Compare
This change introduces a new `Transform` type with a canonical implementation `TransformFunc` that can be used to transform a string at render time. This change also updates the `Style` type to use the new `Transform` type instead of a function type. We need this to support complex transforms and to be able to compare styles using the `==` operator.
aymanbagabas
force-pushed
the
v2-transform
branch
from
1b669f5
to
2e01473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new
Transformtype with a canonical implementationTransformFuncthat can be used to transform a string at render time. This change also updates theStyletype to use the newTransformtype instead of a function type.We need this to support complex transforms and to be able to compare styles using the
==operator.