Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(golden): Removed duplicate fixLineEndings #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pranavkrishnan02
Copy link

  • This function does not work correctly when the byte sequence contains a slice like \r\r\n
  • This is because we're applying fixLineEndings(goldenBts) twice to goldenBts(before writing to the file and after reading from it) and once to out
  • To reproduce, run go test -v ./... -update on https://github.com/caarlos0/teatest-example. Use the latest version of teatest
  • An alternative solution might be to replace all occurrences of the form \r\r\r\r...\n with \n

@pranavkrishnan02 pranavkrishnan02 changed the title Removed duplicate fixLineEndings fix(golden): Removed duplicate fixLineEndings Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant