Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update juju-channel=latest/stable #65

Merged
merged 6 commits into from
Dec 14, 2023

Conversation

addyess
Copy link
Member

@addyess addyess commented Dec 12, 2023

  • Set juju-channel to latest/stable by default rather than 2.9/stable. At this point most charms specify what they want because usually they do not want 2.9/stable
  • update tests to support more current microk8s versions
  • helps the actions-operator be more aware of the juju channel to use appropriate cli switches
  • No longer installs juju > 3.x with --classic

Opened for public comment
image

@addyess addyess force-pushed the juju/update-default-to-latest-stable branch from f035cbe to 15bdcb6 Compare December 12, 2023 14:59
@addyess addyess force-pushed the juju/update-default-to-latest-stable branch 2 times, most recently from 8435e8c to a66e28c Compare December 12, 2023 15:38
@addyess addyess force-pushed the juju/update-default-to-latest-stable branch from a66e28c to e283f22 Compare December 12, 2023 15:47
@addyess addyess force-pushed the juju/update-default-to-latest-stable branch from d88857a to 0c9c407 Compare December 12, 2023 16:43
@addyess addyess force-pushed the juju/update-default-to-latest-stable branch from 0c9c407 to 4dbfa1c Compare December 12, 2023 16:45
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@addyess
Copy link
Member Author

addyess commented Dec 12, 2023

@ca-scribner What do you think about these changes?

@addyess addyess merged commit f0f23fb into main Dec 14, 2023
20 of 21 checks passed
@addyess addyess deleted the juju/update-default-to-latest-stable branch December 14, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants