Only install and refresh lxd once #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
addresses #72 as well by setting the default juju channel to |
addyess
commented
Apr 11, 2024
| default: "latest/stable" | ||
| default: "3/stable" |
There was a problem hiding this comment.
addresses the closing of the latest track of juju
Comment on lines
-5733
to
-5735
| if ([null, ""].includes(channel) == false) { | ||
| yield snap(`refresh lxd --channel=${channel}`); | ||
| } |
There was a problem hiding this comment.
This is no longer necessary with the above change
addyess
force-pushed
the
akd/refresh-lxd-once
branch
from
8ce545d
to
311e8de
Compare
|
@ca-scribner this is ready for a secondary review if you're okay w/ it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes only refresh the lxd snap to a single channel, rather than allowing it to flip to channels during setup
In the event the workflow is called like this:
lxd-channel defaults to
latest/stablethis causes the action to
Rather than going through jumps here, let's let the action install the correct one at the beginning.