Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to actions operator on ubuntu-24.04 #83

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Sep 24, 2024

Overview

@addyess addyess force-pushed the issues/82/ubuntu-24.04-runner branch 2 times, most recently from 963c4d1 to 23ec129 Compare September 24, 2024 02:59
@addyess addyess force-pushed the issues/82/ubuntu-24.04-runner branch 3 times, most recently from 66c43cc to e41e1ae Compare September 24, 2024 13:53
@addyess addyess force-pushed the issues/82/ubuntu-24.04-runner branch from e41e1ae to a5cc90b Compare September 24, 2024 14:53
@addyess addyess changed the title Apply docker_lxd_clash for anything beyond jammy Adjustments to actions operator on ubuntu-24.04 Sep 24, 2024
@addyess addyess force-pushed the issues/82/ubuntu-24.04-runner branch from a047443 to 3ecb692 Compare September 24, 2024 16:04
@addyess addyess force-pushed the issues/82/ubuntu-24.04-runner branch from 3ecb692 to 98364e3 Compare September 24, 2024 16:27
src/bootstrap/index.ts Outdated Show resolved Hide resolved
src/bootstrap/index.ts Show resolved Hide resolved
src/bootstrap/index.ts Show resolved Hide resolved
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple of nits

@addyess addyess force-pushed the issues/82/ubuntu-24.04-runner branch from 98364e3 to 16e93b6 Compare September 24, 2024 19:31
@addyess
Copy link
Member Author

addyess commented Sep 24, 2024

@jnsgruk I believe these changes resolve your issue. Would you like to test from this branch or are you +1 on these changes without testing?

@jnsgruk
Copy link
Contributor

jnsgruk commented Sep 24, 2024

Opened canonical/parca-k8s-operator#346 -- if that looks good then let's get this merged. Thank you!

@jnsgruk
Copy link
Contributor

jnsgruk commented Sep 24, 2024

@jnsgruk
Copy link
Contributor

jnsgruk commented Sep 24, 2024

Okay, we're good I think, thanks for this!

@addyess addyess merged commit b93f710 into main Sep 24, 2024
40 of 42 checks passed
@addyess addyess deleted the issues/82/ubuntu-24.04-runner branch September 24, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants