Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radialLinear: Hide pointLabels of hidden data #10018

Merged
merged 2 commits into from
Dec 22, 2021
Merged

radialLinear: Hide pointLabels of hidden data #10018

merged 2 commits into from
Dec 22, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Dec 22, 2021

Fix #10016

@kurkle kurkle added this to the Version 3.7.0 milestone Dec 22, 2021
LeeLenaleee
LeeLenaleee previously approved these changes Dec 22, 2021
View reviewed changes
etimberg
etimberg requested changes Dec 22, 2021
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to do the map before the filter

src/scales/scale.radialLinear.js Show resolved Hide resolved
@kurkle kurkle merged commit f1c9931 into chartjs:master Dec 22, 2021
@kurkle kurkle deleted the pointLabels branch December 22, 2021 21:09
@LeeLenaleee LeeLenaleee mentioned this pull request Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.7.0
Development

Successfully merging this pull request may close these issues.

Center point labels dont update on data hide polarArea
3 participants
@kurkle @etimberg @LeeLenaleee