Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow array for line opts in dataset #10179

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

resolves #10176

@LeeLenaleee LeeLenaleee changed the title Allow array for line styling in dataset Allow array for line opts in dataset Feb 18, 2022
@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Feb 18, 2022
@LeeLenaleee LeeLenaleee added this to the Version 3.8.0 milestone Feb 18, 2022
@etimberg
Copy link
Member

I tested this out and I'm kind of surprised that it works, though the array only applies to the point colours

line array

@LeeLenaleee
Copy link
Collaborator Author

LeeLenaleee commented Feb 19, 2022

Yeah, not sure if we might want to change it for V4 that you only can do it with the pointBackgroundColor etc. Since it doesnt work for fill and line segments etc like you might expect it to do.

But for V3 it needs to be typed correctly, edited it now so the current opts stay as is, because otherwise some would become invalid. And added the common element ops and hover opts which are the ones that support array format as seperate entries that gets extended from

@etimberg etimberg merged commit 16e6acc into chartjs:master Feb 21, 2022
@LeeLenaleee LeeLenaleee deleted the types/line-array-opts branch February 21, 2022 06:32
@Slion
Copy link

Slion commented Feb 22, 2022

Thanks guys for the quick turnaround. I was using this feature since I have so many points the line segments are not visible anyway. However what I would really need is to be able to set the line segments colors. I came across #9692 and was wondering if this is what I was looking for. I have yet to try it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants