Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import helpers #10552

Merged
merged 1 commit into from
Aug 3, 2022
Merged

fix import helpers #10552

merged 1 commit into from
Aug 3, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

@LeeLenaleee LeeLenaleee commented Aug 3, 2022

Resolves: #10547

@etimberg
Copy link
Member

etimberg commented Aug 3, 2022

What's a good way to test this?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok

@LeeLenaleee
Copy link
Collaborator Author

LeeLenaleee commented Aug 3, 2022

What's a good way to test this?

Steps I use to test these kind of things:

  1. Create clean project: npx create-react-app test-chartjs-changes
  2. Install chart.js: npm i chart.js
  3. Go into the node modules folder into chart.js and make the changes you want to test
  4. Remove the .bin and .cache folder in the root of the node modules
  5. Run npm i again so it builds all the packages again but with your own changes
  6. Import a helper function in App.js: import {merge} from 'chart.js/helpers'
  7. Put console log to see it got imported correctly: console.log(merge)
  8. Run npm start to run dev server
  9. It should build without errors and show the merge function in the console

@kurkle
Copy link
Member

kurkle commented Aug 3, 2022

We could add simple projects as integration tests for different platforms.

@LeeLenaleee LeeLenaleee merged commit aa5e7e5 into chartjs:3.9 Aug 3, 2022
@LeeLenaleee
Copy link
Collaborator Author

@etimberg can you do a manual release of 3.9.1 because this also affects plugins.

@etimberg
Copy link
Member

etimberg commented Aug 3, 2022

Will do! I think it can be done entirely with the GitHub UI but will need to manually create the release on the correct branch.

@LeeLenaleee can you send a PR to the 3.9 branch bumping the package.json version number?

@LeeLenaleee LeeLenaleee deleted the fix-import-helpers branch August 3, 2022 12:43
@LeeLenaleee LeeLenaleee restored the fix-import-helpers branch August 3, 2022 12:57
@LeeLenaleee LeeLenaleee deleted the fix-import-helpers branch August 3, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants