Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decimation plugin data not writeable after clean #11045

Merged
merged 3 commits into from
Feb 10, 2023
Merged

fix: decimation plugin data not writeable after clean #11045

merged 3 commits into from
Feb 10, 2023

Conversation

johakr
Copy link
Contributor

@johakr johakr commented Jan 10, 2023

When using the decimation plugin and changing data it will throw Uncaught TypeError: Cannot assign to read only property 'data' of object '#<Object>', because the data property is not writeable anymore after cleanup.

Changing from defineProperty (default writable false) to normal property assignment, will fix the issue.

@johakr johakr requested a review from kurkle January 10, 2023 21:25
@kurkle
Copy link
Member

kurkle commented Jan 11, 2023

Wondering if its possible to store the original definition and use that when restoring. In case its read only initially, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants