-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fixes compilation error when option --isolatedModules is set #11095
🐛 fixes compilation error when option --isolatedModules is set #11095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't do this until V5 since this will be a breaking change.
I guess the beaking change here is the removal of Instead of removing |
I think this would be safe to make |
It might still be breaking without const, I know TS will do strange compile things with that. I think @dangreen might be able to answer that better if it will break things since he is more into TS than me |
@LeeLenaleee @etimberg @jljouannic Hi. For me, it looks like a minor change.
|
Could we release this soon? 🙏 I'm not able to use the lib in the project with Thank you! |
Fixes #11094