Common logic for resolving element options #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
requested changes
Jan 22, 2019
kurkle
requested changes
Jan 22, 2019
There was a problem hiding this comment.
Almost ready IMO,
one line can be saved and I agree with @simonbrunel with the function names.
benmccann
force-pushed
the
resolve-element-ops-2
branch
from
e172a50
to
4d1c4b0
Compare
kurkle
previously approved these changes
Jan 22, 2019
etimberg
previously approved these changes
Jan 23, 2019
simonbrunel
requested changes
Jan 23, 2019
simonbrunel
approved these changes
Jan 29, 2019
kurkle
approved these changes
Jan 29, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.