Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setActiveElements behavior after a mouse event #9992

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Fix setActiveElements behavior after a mouse event #9992

merged 2 commits into from
Dec 16, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Dec 15, 2021

Fix #9989

@kurkle kurkle added this to the Version 3.7.0 milestone Dec 15, 2021
etimberg
etimberg previously approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the internal variable name

src/plugins/plugin.tooltip.js Outdated Show resolved Hide resolved
@kurkle kurkle merged commit 0d250a1 into chartjs:master Dec 16, 2021
@kurkle kurkle deleted the set-active-replay branch December 16, 2021 22:34
@chrispahm chrispahm mentioned this pull request Dec 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.7.0
Development

Successfully merging this pull request may close these issues.

setActiveElements does not always work
2 participants
@kurkle @etimberg