Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct imports for v3 #31

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Correct imports for v3 #31

merged 1 commit into from
Mar 7, 2021

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Mar 7, 2021

No description provided.

@etimberg etimberg added the bug label Mar 7, 2021
@etimberg etimberg linked an issue Mar 7, 2021 that may be closed by this pull request
Support for Chart.js v3 - import error: 'chart.js' does not contain a default export (imported as 'Chart') #28
Closed
@coveralls
Copy link

coveralls commented Mar 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 630218597

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.175%
Totals Coverage Status
Change from base Build 630196825: 0.0%
Covered Lines: 23
Relevant Lines: 31
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 630218597

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.175%
Totals Coverage Status
Change from base Build 630196825: 0.0%
Covered Lines: 23
Relevant Lines: 31
💛 - Coveralls

@etimberg etimberg merged commit ed22e29 into chartjs:master Mar 7, 2021
@etimberg etimberg deleted the fix-v3-imports branch March 7, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Chart.js v3 - import error: 'chart.js' does not contain a default export (imported as 'Chart')
3 participants
@etimberg @coveralls @kurkle