Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typeof invocation when parsing #68

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

stockiNail
Copy link
Contributor

The typeof was invoked twice in the parse method, to check if undefined (in if statement) and later to get the type.
Moved before consistency check in order to invoke only one when the value argument is not null.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2668870414

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 72.727%

Files with Coverage Reduction New Missed Lines %
src/index.js 2 72.73%
Totals Coverage Status
Change from base Build 2085427674: 0.0%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2668870414

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 72.727%

Files with Coverage Reduction New Missed Lines %
src/index.js 2 72.73%
Totals Coverage Status
Change from base Build 2085427674: 0.0%
Covered Lines: 24
Relevant Lines: 31

💛 - Coveralls

@kurkle kurkle merged commit 84c3d1b into chartjs:master Jul 26, 2022
@stockiNail stockiNail deleted the improveTypeCalculation branch July 26, 2022 07:19
@kurkle kurkle added this to the 1.2.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants