Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default type from module augmentation of PluginOptionsByType #894

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

stockiNail
Copy link
Collaborator

Fix #886 revert #877 because the the root cause of the bug was different and fixed in CHART.JS by chartjs/Chart.js#11309

Waiting for new CHART.JS version here the mentioned above PR will be published.

@stockiNail stockiNail added the types Typescript type changes label May 25, 2023
@stockiNail stockiNail added this to the 3.1.0 milestone May 25, 2023
@stockiNail stockiNail marked this pull request as ready for review September 18, 2024 11:38
@stockiNail stockiNail merged commit 04fcde5 into chartjs:master Sep 19, 2024
10 checks passed
@stockiNail stockiNail deleted the revert877 branch September 19, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types Typescript type changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object literal may only specify known properties, and 'annotation' does not exist in specified type
2 participants