Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Revert "userland-proxy=false is not required anymore" #251

Closed
wants to merge 1 commit into from

Conversation

sleshchenko
Copy link
Contributor

What does this PR do?

This reverts commit b862e0e.

It follows the following email posted to che-dev https://www.eclipse.org/lists/che-dev/msg03375.html

Which minishift/minikube problems this PR fixes:

  1. NodeJS + Mongo Devfile is working again. It can be fixed in an alternative way, and use localhost for application->DB communication.
  2. If a user defines in their Devfile multiple Deployments and Service for setting up communication - it will work again. Like an example https://github.com/redhat-developer/devfile/blob/master/samples/web-nodejs-with-db-sample/devfile.yaml
  3. Discoverable endpoints work again. User may declare them in dockerimage component. As an example, the NodeJS+Mongo Devfile referenced above.

⚠️ It's has WIP in the title because it was created to get feedback and concerns about requiring userland-proxy=false again

What issues does this PR fix or reference?

eclipse-che/che#14009

This reverts commit b862e0e.

# Conflicts:
#	README.md

Signed-off-by: Sergii Leshchenko <[email protected]>
@sleshchenko sleshchenko changed the title WIP Revert "userland-proxy=false is not required anymore" 🚧 Revert "userland-proxy=false is not required anymore" Aug 14, 2019
@sleshchenko sleshchenko changed the title 🚧 Revert "userland-proxy=false is not required anymore" WIP Revert "userland-proxy=false is not required anymore" Aug 14, 2019
@benoitf
Copy link
Collaborator

benoitf commented Aug 14, 2019

I think you have valid arguments but other previous valid arguments were that restarting minishift or minikube with these settings need mostly to recreate the VMs and from UX it's not so nice to not be able to use the instance already there

@sleshchenko
Copy link
Contributor Author

@benoitf

I think you have valid arguments but other previous valid arguments were that restarting minishift or minikube with these settings need mostly to recreate the VMs and from UX it's not so nice to not be able to use the instance already there

Should we print add like the following warning?

If you do specify `userland-proxy=false` then discoverable endpoints[see doc] in workspaces won't work. You can skip this checking by `--skip-userland-proxy-check`

Or maybe we even are able to do interactive option:

If you do specify `userland-proxy=false` then discoverable endpoints[see doc] in workspaces won't work.
Type `Y` if you are want to proceed without discoverable endpoints functionality:

Messages are just examples and definitely must be better.

@benoitf
Copy link
Collaborator

benoitf commented Aug 14, 2019

@sleshchenko is that che infra is able to check that a user is adding discoverable endpoints in its devfile, etc and then report that if userland-proxy=false it won't work as well ?

@sleshchenko
Copy link
Contributor Author

@sleshchenko is that che infra is able to check that a user is adding discoverable endpoints in its devfile, etc and then report that if userland-proxy=false it won't work as well ?

Good idea, but I doubt that it can check it. chectl could provide this info for Che Server with env var.
BTW user then may face this issue with their own K8s components with multiple deployments and services

@tolusha tolusha closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants