Add error logging to kerndat init #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently looking into the travis failures. |
|
Please, check Travis-CI, it's very red. |
The commit history of your pull request has to be clean. If you find a bug in one of your commits, you don't need to create another commit to fix it, instead of this, you have to merge the fix into the target commit. |
avagin
reviewed
Jul 8, 2020
criu/kerndat.c
Outdated
| ret = kerndat_has_thp_disable(); | ||
| if (check_pagemap()) { | ||
| pr_err("check_pagemap failed when initializing kerndat.\n"); | ||
| ret = 1; |
There was a problem hiding this comment.
ret = -1
nit: usually, we use -1 or another negative value in an error case
There was a problem hiding this comment.
Ah, thanks for letting me know! That's a good one to know :)
CRIU sometimes returns 1 from main() with no explanation. These changes add additional logging for initialization errors in kerndat. Signed-off-by: Angie Ni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRIU sometimes returns 1 from main() with no explanation.
These changes add additional logging for initialization errors in kerndat.
There may be discourse surrounding the messages themselves -- specific alternatives are written and recorded elsewhere for each "foo failed" message. Given the large number of functions I've written error messages for in this commit, it may be safer to start with generic "foo failed" messages. These can be replaced depending on the preference of the CRIU maintainers.
Signed-off-by: Angie Ni [email protected]