Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/other: add test for action-script #2191

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

rst0git
Copy link
Member

@rst0git rst0git commented Jun 6, 2023

This pull request is introducing a test for the action-script functionality of CRIU to verify that pre-dump, post-dump, pre-restore, pre-resume, post-restore, and post-resume hooks are executed during dump/restore.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (a4bb3f9) 70.27% compared to head (c82040e) 70.33%.

❗ Current head c82040e differs from pull request most recent head a1d5e2f. Consider uploading reports for the commit a1d5e2f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           criu-dev    #2191      +/-   ##
============================================
+ Coverage     70.27%   70.33%   +0.06%     
============================================
  Files           133      133              
  Lines         33994    33986       -8     
============================================
+ Hits          23888    23904      +16     
+ Misses        10106    10082      -24     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This commit is introducing a test for the action-script functionality
of CRIU to verify that pre-dump, post-dump, pre-restore, pre-resume,
post-restore, post-resume hooks are executed during dump/restore.

Signed-off-by: Radostin Stoyanov <[email protected]>
Copy link
Member

@Snorch Snorch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test.

Note: would be good to have other script points also covered later, like setup-namespaces, post-setup-namespaces, which are only called in case root_ns_mask is not 0, and maybe others

[ACT_PRE_STREAM] = "pre-stream",
.

@avagin avagin merged commit 2df6ec5 into checkpoint-restore:criu-dev Aug 25, 2023
32 of 37 checks passed
@rst0git rst0git deleted the action-script-tests branch August 26, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants