seize: fix error handling for check_freezer_cgroup #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rst0git
force-pushed
the
2024-11-04-seize-error-handling
branch
2 times, most recently
from
63dc0f7
to
baf6683
Compare
rst0git
force-pushed
the
2024-11-04-seize-error-handling
branch
2 times, most recently
from
ea03746
to
9537341
Compare
avagin
reviewed
Nov 4, 2024
When `check_freezer_cgroup()` has non-zero return value, `goto err` calls `return ret`. However, the value of `ret` has been set to `0` in the lines above and CRIU does not handle the error properly. This problem is related to checkpoint-restore#2508 Signed-off-by: Radostin Stoyanov <[email protected]>
rst0git
force-pushed
the
2024-11-04-seize-error-handling
branch
from
9537341
to
3565136
Compare
|
Merged. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
check_freezer_cgroup()has non-zero return value,goto errcallsreturn ret. However, the value ofrethas been set to0in the lines above and CRIU does not handle the error properly.This problem is related to #2508