major rewrite, fixes #16 and #17 #19
Conversation
rindeal
commented
Jul 25, 2015
rindeal
commented
- feature exclude pinned tabs #17 is not complete
- needs to set up hooks to update counters on pinned/unpinned events
- code tested on FF 39.0
| var maxPrivateBrowsing = simplePrefs.prefs.maxPrivateBrowsing; | ||
| var maxOpenInNextWindow = simplePrefs.prefs.maxOpenInNextWindow; |
There was a problem hiding this comment.
Could you fix the spaces (or tabs)? I use tabs so let's stick to that 😄
|
Hi! I tested on 41.0a and the tab moved to the new window isn't being focused. Doesn't the window need to be activated too? Or is it a Firefox Alpha bug? |
|
It does and it is not. I've also noticed this behaviour. Also there seems to be a bug which causes the counter to reach one tab above limit. I don't have enough time to dig into it now, but I'll try it this weekend. |
|
Hi! I'm testing and... It's annoying to have to wait until the page to completely load before the tab to be "moved". However, I can't figure anything different from a loop on setTimeout, but I'm afraid of performance issues. |
|
Hi, docs clearly say that URL of tab is known only after the tab entered "ready" state. And as I stated in comments in the code, unless you want to implement the low level stuff to enable true moving of tabs, this is the only way of doing it, AFAIK (however, I don't know too far in this field). BTW, which loop do you mean @robsonsobral? |
|
I'm sorry! I mean I was thinking on to use the |
|
Wow, there was an error in Matrix! I'd swear that yesterday the sentence was |
|
Hi! I've testing this branch and found a bug. If the new tab is just a file, like Maybe it's best to use setInterval until the URl of the tab become available. |
|
One more issue: the moved tab isn't integrated into history. It doesn't appears on "recent closed tabs" and sometimes just doesn't keep its url after reload. It looks like this idea isn't easy to implemented after all. |
