use single quotes for values that contain double quotes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fb55 any chance you can take a look at this? Thanks! |
|
+1 had the same problem with .. style = 'font-family: "Geneva";'> ... being serialized to style = "font-family: "Geneva";"> |
|
This also fixed my problem on a page that had JSON within an html element within single quotes: |
|
This patch looks legitimate and addresses an important issue for parsing many Websites (e.g. msn.com and many others in the Alexa Top 100). Is there a reason the merge is being held off? |
Matthalp-zz
pushed a commit
to Matthalp-zz/dom-serializer
that referenced
this pull request
Oct 15, 2016
Implementation of PR: cheeriojs#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use single quotes for attributes instead of double quotes, when the value contains double quotes.
Fix for cheeriojs/cheerio#720