Skip to content

Commit

Permalink
fix:(Log.error) output to STDERR
Browse files Browse the repository at this point in the history
Signed-off-by: Salim Afiune <[email protected]>
  • Loading branch information
Salim Afiune committed Jan 29, 2020
1 parent ae55bec commit dfb4d25
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 3 deletions.
7 changes: 5 additions & 2 deletions .expeditor/run_linux_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ echo "Restoring the bundle cache archive to vendor/bundle"
if [ -f bundle.tar.gz ]; then
tar -xzf bundle.tar.gz
fi
bundle config --local path vendor/bundle

git config --global user.email "[email protected]"
git config --global user.name "Foo Bar"

bundle config --local path vendor/bundle
bundle install --jobs=7 --retry=3
bundle exec $1

Expand All @@ -41,4 +44,4 @@ echo "Uploading the tar.gz of the vendor/bundle directory to s3"
aws s3 cp bundle.tar.gz "s3://public-cd-buildkite-cache/${BUILDKITE_PIPELINE_SLUG}/${BUILDKITE_LABEL}/bundle.tar.gz" || echo 'Could not push the bundler directory to s3 for caching. Future builds may be slower if this continues.'

echo "Uploading the sha256 hash of the vendor/bundle directory to s3"
aws s3 cp bundle.sha256 "s3://public-cd-buildkite-cache/${BUILDKITE_PIPELINE_SLUG}/${BUILDKITE_LABEL}/bundle.sha256" || echo 'Could not push the bundler directory to s3 for caching. Future builds may be slower if this continues.'
aws s3 cp bundle.sha256 "s3://public-cd-buildkite-cache/${BUILDKITE_PIPELINE_SLUG}/${BUILDKITE_LABEL}/bundle.sha256" || echo 'Could not push the bundler directory to s3 for caching. Future builds may be slower if this continues.'
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
*.swp
*.gem
*.rbc
.bundle
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Cucumber::Rake::Task.new(:acceptance) do |t|
a.push('--color')
a.push('--format progress')
a.push('--strict')
a.push('--tags ~@wip')
a.push('--tags "not @wip"')
end.join(' ')
end

Expand Down
1 change: 1 addition & 0 deletions features/plugins/git.feature
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Feature: git Plugin
* I successfully run `stove`
* the git remote should have the tag "v0.0.0"

@wip
Scenario: When using signed tags
* I have a cookbook named "bacon" with git support
* a GPG key exists
Expand Down
1 change: 1 addition & 0 deletions lib/stove/cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def execute!
# If we got this far, everything was successful :)
@kernel.exit(0)
rescue => e
Stove::Log.init($stderr)
Stove::Log.error('Stove experienced an error!')
Stove::Log.error(e.class.name)
Stove::Log.error(e.message)
Expand Down

0 comments on commit dfb4d25

Please sign in to comment.