Fix line updates #35
Merged
Fix line updates #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, lines were not properly cleared. This meant that updating the message of a spinner could result in text being incorrectly displayed. This would have been more noticeable when the updated message was shorted than the original message. This commit fixes that by adding a new ClearLine method to the tput package and using it to ensure that each line is cleared before it is rendered.
This commit adds a new example that shows how ysmrr could be used in a more complex application.
chelnak
force-pushed
the
fix_line_updates
branch
from
944d911
to
f3e930b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, lines were not properly cleared. This meant that updating the message of a spinner could result in text being incorrectly displayed. This would have been more noticeable when the updated message was shorter than the original message.
This commit fixes that by adding a new ClearLine method to the tput package and using it to ensure that each line is cleared before it is rendered.