Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take control of instances of injected driver. #55

Merged
merged 1 commit into from
Apr 6, 2014

Conversation

mCzolko
Copy link
Contributor

@mCzolko mCzolko commented Apr 6, 2014

I forgot a little thing. When you run f.e.: record, recoding creates an instance of webdriver and after calls method quit() after recoding is complete. Then starts playback which creates a new instance of webdriver. Injected driver must be pass as anonymous function to get control of instances (as you can see in commit diff).

@chenglou
Copy link
Owner

chenglou commented Apr 6, 2014

lol damn, so it didn't work before? Since huxley would be trying to access stuff like driver.takeScreenshot() of a function rather than the returned driver.

@mCzolko
Copy link
Contributor Author

mCzolko commented Apr 6, 2014

it didnt work before, sorry, my bad. I cannot continue quited driver any more (quit() method called on browser driver)

@chenglou
Copy link
Owner

chenglou commented Apr 6, 2014

Ok. So this PR will fix everything?
Also, might wanna write a test that injects a mock driver to see if everything goes alright.

@mCzolko
Copy link
Contributor Author

mCzolko commented Apr 6, 2014

yeah, it fix everything. And I wrote a test that injects driver before. But you are the only one who can run the test, just because I dont have the same environment as you. (All these commits are about testing with huxley in team :) )

@chenglou
Copy link
Owner

chenglou commented Apr 6, 2014

Oh wait, yeah...
Alright, pulling this in.

chenglou added a commit that referenced this pull request Apr 6, 2014
Take control of instances of injected driver.
@chenglou chenglou merged commit 1ea8397 into chenglou:master Apr 6, 2014
@mCzolko
Copy link
Contributor Author

mCzolko commented Apr 6, 2014

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants