fix: fix data race around spop Dobinlog (OpenAtomFoundation#2674)

* fix spop binlog data race * adjust format --------- Co-authored-by: cjh <[email protected]>
cheniujh · May 24, 2024 · bd54c1e · bd54c1e
1 parent e9792ba
commit bd54c1e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/include/pika_set.h b/include/pika_set.h
@@ -66,8 +66,12 @@ class SPopCmd : public Cmd {
  public:
   SPopCmd(const std::string& name, int arity, uint32_t flag)
       : Cmd(name, arity, flag, static_cast<uint32_t>(AclCategory::SET)) {
-        srem_cmd_ = std::make_shared<SRemCmd>(kCmdNameSRem, -3, kCmdFlagsWrite |  kCmdFlagsSet);
-      }
+    srem_cmd_ = std::make_shared<SRemCmd>(kCmdNameSRem, -3, kCmdFlagsWrite | kCmdFlagsSet);
+  }
+  SPopCmd(const SPopCmd& other)
+      : Cmd(other), key_(other.key_), members_(other.members_), count_(other.count_), s_(other.s_) {
+    srem_cmd_ = std::make_shared<SRemCmd>(kCmdNameSRem, -3, kCmdFlagsWrite | kCmdFlagsSet);
+  }
   std::vector<std::string> current_key() const override {
     std::vector<std::string> res;
     res.push_back(key_);