Added SugarDataSource #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 16, 2016 19:30
Added ThreadUtil class which provides a methoc to perform a generic async execution of a callable Added SugarDataSource class which provides async execution of SugarRecord and result via callbacks.
Start adding SugarDataSourceTest to test all DataSource functionallity
|
By analyzing the blame information on this pull request, we identified @nurolopher, @sibeliusseraphini and @whoshuu to be potential reviewers |
Added bulkInsert test and datasource constructor test
added 2 commits
April 17, 2016 13:32
Modified from private to protected
|
as this do not modify Sugar API, and LGTM, I'll merge it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SugarDataSource class which works on top of SugarRecord class and provides asynchronous execution of tasks using Futures and returns data via success and error callbacks.
This approach is good for those who use MVP pattern in their applications and this class can be combined with a Repository Pattern easily.