Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Serializable fields #642

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sami-b95
Copy link

@sami-b95 sami-b95 commented Jul 17, 2016

This slight addition allows to store into database any object field type implementing the Serializable interface in addition to the Java types already supported. For instance, (small) lists or maps of Serializable types can now be stored into database without creating additional models or writing boilerplate serialization/deserialization code to/from BLOB.

@mention-bot
Copy link

@sami-b95, thanks for your PR! By analyzing the annotation information on this pull request, we identified @JonatanSalas, @sibelius and @whoshuu to be potential reviewers

@JonatanSalas
Copy link
Collaborator

JonatanSalas commented Jul 17, 2016

@sami-b95 would you like to check why the tests are breaking? If you fix this and the build pass I will check the code a little bit, and then I will merge to the master.

@sami-b95
Copy link
Author

sami-b95 commented Jul 17, 2016

Thanks for your response @JonatanSalas. I have amended the code so as to pass all the tests except one (defined in class com.orm.helper.NamingHelperTest). The reason is this test indirectly calls ContextUtils.getPackageManager(), but ContextUtils.ctx is null when it occurs, resulting in an NullPointerException. I have tried to execute the tests on my own machine, and I end up with the same error, not only on my forked branch but also on the current master branch. Any idea what the issue may be ?

@JonatanSalas
Copy link
Collaborator

@sami-b95 The ctx needs to be setted, because sugarORM relies on it. If I can, I will try to take a look at it to fix the test cases that are broken.

@sibelius
Copy link
Contributor

sibelius commented Sep 2, 2016

@sami-b95 try to rebase ur commits with master

maybe this commit could help: e93b2f1

by @Vookash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants