Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete option to recording complete notifications #179

Closed
chenxiaolong opened this issue Nov 28, 2022 · 0 comments · Fixed by #182
Closed

Add delete option to recording complete notifications #179

chenxiaolong opened this issue Nov 28, 2022 · 0 comments · Fixed by #182
Assignees
@chenxiaolong
Labels
enhancement New feature or request

Comments

@chenxiaolong
Copy link
Owner

From #177 (comment):

I wanted to suggest another small option. Once a call is completed, a notification currently pops up in the notification area saying recording completed with 2 options, open and share. If u could add delete also to it that will give us the option to delete unwanted recordings right after that call.
@chenxiaolong chenxiaolong added the enhancement New feature or request label Nov 28, 2022
@chenxiaolong chenxiaolong self-assigned this Nov 28, 2022
@chenxiaolong chenxiaolong mentioned this issue Nov 28, 2022
Closed
chenxiaolong added a commit that referenced this issue Nov 28, 2022
@chenxiaolong
Add a new notification action for deleting the recording
72683bb 
The delete option will show up alongside the current Open and Share
actions, but unlike those other two actions, Delete will also dismiss
the notification.

Fixes: #179

Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong mentioned this issue Nov 28, 2022
Merged
chenxiaolong added a commit that referenced this issue Nov 28, 2022
@chenxiaolong
Add a new notification action for deleting the recording
e8e8c5c 
The new Delete action will show up alongside the current Open and Share
actions, but unlike those other two actions, Delete will also dismiss
the notification.

Fixes: #179

Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong added a commit that referenced this issue Nov 28, 2022
@chenxiaolong
Add a new notification action for deleting the recording
3cb2b91 
The new Delete action will show up alongside the current Open and Share
actions, but unlike those other two actions, Delete will also dismiss
the notification.

Fixes: #179

Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong added a commit that referenced this issue Nov 28, 2022
@chenxiaolong
Add a new notification action for deleting the recording
f23577a 
The new Delete action will show up alongside the current Open and Share
actions, but unlike those other two actions, Delete will also dismiss
the notification.

Fixes: #179

Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong added a commit that referenced this issue Nov 28, 2022
@chenxiaolong
Add a new notification action for deleting the recording
dffee80 
The new Delete action will show up alongside the current Open and Share
actions, but unlike those other two actions, Delete will also dismiss
the notification.

Fixes: #179

Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong added a commit that referenced this issue Nov 28, 2022
@chenxiaolong
Add a new notification action for deleting the recording
df042ba 
The new Delete action will show up alongside the current Open and Share
actions, but unlike those other two actions, Delete will also dismiss
the notification.

Fixes: #179

Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a new notification action for deleting the recording chenxiaolong/BCR
1 participant
@chenxiaolong