Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't tap on seek bar nor total duration is showing #19

Closed
CodElixer opened this issue May 23, 2022 · 6 comments · Fixed by #20
Closed

Can't tap on seek bar nor total duration is showing #19

CodElixer opened this issue May 23, 2022 · 6 comments · Fixed by #20
Assignees
@chenxiaolong
Labels
bug Bug in BCR itself

Comments

@CodElixer
Copy link

I'm on BCR v1.2 and can't tap on the seek bar(audio progress bar) in any media player while playing the recorded calls, due to this not able to tap on a timestamp to play recording at a desired time.
Also the total duration of audio is not showing in the player.
@chenxiaolong
Copy link
Owner

Could you try making a call recording and upload it here? Only needs to be a few seconds and it can be silent, no need to talk.

BCR uses Android's built-in FLAC encoder and I suspect the one included in your ROM is broken. It's not a frequently used part of Android and is kind of buggy even on AOSP and the Google Pixel stock ROM.

@SalvatoreNoschese
Copy link

SalvatoreNoschese commented May 23, 2022 •
edited
Loading

Same for me.
Screenshot_20220523-164520_Solid Explorer

File:
https://drive.google.com/uc?id=1wGyS38odjwqyhPkcRGhevrGnGTXoW4Sy&export=download

Also, as u can see, no file name (just phone number: 160) in latest file (maked with latest 1.2 release).

Maybe u can consider to use mp3 or wav (more and best supported)?

@CodElixer
Copy link
Author

CodElixer commented May 23, 2022 •
edited
Loading

Could you try making a call recording and upload it here? Only needs to be a few seconds and it can be silent, no need to talk.

BCR uses Android's built-in FLAC encoder and I suspect the one included in your ROM is broken. It's not a frequently used part of Android and is kind of buggy even on AOSP and the Google Pixel stock ROM.

File link: https://easyupload.io/g4z7ao

I've uploaded it. Please check this.

FYI: I'm using Poco F1 device with Pixel Experience Plus Android 12L ROM.

It'd be better if you could provide other formats too like .mp3/.wav as flac is also taking more space than .mp3 recordings.

@chenxiaolong
Copy link
Owner

Thanks for uploading the sample files. I'm able to reproduce the issue myself now. I didn't notice this before because I was playing the audio with VLC, which can automatically determine the audio duration when it is not specified in the file.

I'll investigate a bit after work and see if I can figure out how to add the duration (total audio samples) to the FLAC metadata. Android's built-in MediaCodec API doesn't support this so BCR will need to manually edit the file after the recording completes.

chenxiaolong added a commit that referenced this issue May 23, 2022
@chenxiaolong
RecorderThread: Write duration to FLAC STREAMINFO metadata block
2f3f227 
MediaCodec's FLAC encoder does not write the final duration to the
STREAMINFO metadata block. The streaming nature of the API makes that
impossible. Instead, when the recording completes, BCR will find the
STREAMINFO block and update the total frame count field manually.

This fixes seeking in audio players that don't try to guess the length
of the audio file.

Fixes: #19
Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong mentioned this issue May 23, 2022
Merged
@chenxiaolong
Copy link
Owner

This is fixed in #20 and will be included in version 1.3.

@chenxiaolong chenxiaolong self-assigned this May 23, 2022
@chenxiaolong chenxiaolong added the bug Bug in BCR itself label May 23, 2022
@CodElixer
Copy link
Author

This is fixed in #20 and will be included in version 1.3.

Thanks! I can confirm this issue has been fixed on the latest v1.3 of BCR👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
bug Bug in BCR itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RecorderThread: Write duration to FLAC STREAMINFO metadata block chenxiaolong/BCR
3 participants
@chenxiaolong @SalvatoreNoschese @CodElixer