-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCR sometimes incorrectly uses .mp3 file extension #292
Labels
bug
Bug in BCR itself
Comments
Ugh, this is an Android bug/inconsistency:
This becomes a problem any time the output file needs to be renamed (eg. custom filename template or contact name changed during the call, etc.). The flow that causes the issue:
This should be pretty easy to fix. When renaming a file, instead of asking Android for the file type, we'll just specify it since we know what it should be. |
chenxiaolong
added a commit
that referenced
this issue
Apr 14, 2023
…xtension when renaming MimeTypeMap's getExtensionFromMimeType() and getMimeTypeFromExtension() are not consistent with each other. Querying the extension for `audio/mp4` returns `m4a` as expected, but querying the MIME type for `m4a` returns `audio/mpeg`, which is associated with the `mp3` extension. Due to this, whenever an output file needed to be renamed, files that originally had the `m4a` extension would get changed to `mp3`. This commit fixes the issue by removing the whole extension -> MIME type -> extension round trip when renaming files. Instead, it just appends everything after the last dot from the original filename when renaming. Fixes: #292 Signed-off-by: Andrew Gunnerson <[email protected]>
PatrykMis
pushed a commit
to PatrykMis/BAR
that referenced
this issue
Jun 1, 2023
…xtension when renaming MimeTypeMap's getExtensionFromMimeType() and getMimeTypeFromExtension() are not consistent with each other. Querying the extension for `audio/mp4` returns `m4a` as expected, but querying the MIME type for `m4a` returns `audio/mpeg`, which is associated with the `mp3` extension. Due to this, whenever an output file needed to be renamed, files that originally had the `m4a` extension would get changed to `mp3`. This commit fixes the issue by removing the whole extension -> MIME type -> extension round trip when renaming files. Instead, it just appends everything after the last dot from the original filename when renaming. Fixes: chenxiaolong#292 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
added a commit
that referenced
this issue
Jul 2, 2023
This fixes a regression in #361, which reintroduced #292/#293. Fixes: #367 Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From #284 (comment):
The text was updated successfully, but these errors were encountered: