Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to add android 9.0 (Pie) Compatibility? #6

Closed
Dusk-Golem opened this issue May 22, 2022 · 1 comment · Fixed by #10
Closed

Possible to add android 9.0 (Pie) Compatibility? #6

Dusk-Golem opened this issue May 22, 2022 · 1 comment · Fixed by #10
Assignees
@chenxiaolong
Labels
enhancement New feature or request

Comments

@Dusk-Golem
Copy link

Hello, So can you possibly add this? I know android 9 is very old now but still, if you can, please add it.
chenxiaolong added a commit that referenced this issue May 22, 2022
@chenxiaolong
Add support for API 28
7dcfb64 
There was only one API call, AudioFormat.getFrameSizeInBytes(), that
required at least API 29. It's trivial enough to reimplement that
function manually.

Fixes: #6
Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong added a commit that referenced this issue May 22, 2022
@chenxiaolong
Add support for API 28
8131563 
There was only one API call, AudioFormat.getFrameSizeInBytes(), that
required at least API 29. It's trivial enough to reimplement that
function manually.

Fixes: #6
Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong mentioned this issue May 22, 2022
Merged
@chenxiaolong
Copy link
Owner

Implemented in #10. It turned out to be easier than expected because there was only a single API call that needed a workaround for API 28 (Android 9) compatibility.

It'll be supported in the next version.

@chenxiaolong chenxiaolong self-assigned this May 22, 2022
@chenxiaolong chenxiaolong added the enhancement New feature or request label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for API 28 chenxiaolong/BCR
2 participants
@chenxiaolong @Dusk-Golem