Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of Giving Contacts Permission Manually add a Pop-Up which asks for Contacts Permission On first start like Microphone Premission. #80

Closed
DesignVertex opened this issue Jun 15, 2022 · 2 comments · Fixed by #84
Closed

Instead of Giving Contacts Permission Manually add a Pop-Up which asks for Contacts Permission On first start like Microphone Premission. #80

DesignVertex opened this issue Jun 15, 2022 · 2 comments · Fixed by #84
Assignees
@chenxiaolong
Labels
enhancement New feature or request

Comments

@DesignVertex
Copy link

It's frustating to manually go into App Info and enable Permission...
@chenxiaolong chenxiaolong self-assigned this Jun 15, 2022
@chenxiaolong chenxiaolong added invalid Not a bug or invalid assumptions enhancement New feature or request and removed invalid Not a bug or invalid assumptions labels Jun 15, 2022
@chenxiaolong
Copy link
Owner

I'll be making this part of the initial permissions prompt in the next version.

chenxiaolong added a commit that referenced this issue Jun 15, 2022
@chenxiaolong
SettingsActivity: Prompt for optional contacts permission on first en…
f041a94 
…able

The contacts permission is used to add the contact name to the output
filenames. The permission prompt will only be shown the first time call
recording is enabled. If the user chooses to not allow the permission,
but wants to allow it later, they will have to do so via the system
settings.

Fixes: #78
Fixes: #80

Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong mentioned this issue Jun 15, 2022
Merged
@chenxiaolong
Copy link
Owner

This has been implemented in #84 and will be part of version 1.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenxiaolong chenxiaolong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SettingsActivity: Prompt for optional contacts permission on first enable chenxiaolong/BCR
2 participants
@chenxiaolong @DesignVertex