app/proguard-rules.pro: Keep TreeDocumentFile constructor #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We call it via reflection in our faster DocumentFile extensions and the first parameter was being optimized out in release builds because it is always null in the usages that R8 is able to analyze. Related-to: #257 Fixes: #260 Signed-off-by: Andrew Gunnerson <[email protected]>
It basically serves as a debug-signed release build. Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
added a commit
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call it via reflection in our faster DocumentFile extensions and the first parameter was being optimized out in release builds because it is always null in the usages that R8 is able to analyze.
Related-to: #257
Fixes: #260