Improve conference call handling #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build: BCR-1.39.r2.gebf87ed-debugOpt.zip |
* RecorderInCallService and RecorderThread have been updated to be aware of parent/child relationships of calls. Previously, child calls were treated as independent calls, so a conference call would result in separate (but identical in audio) recordings for the parent conference call and every call it was merged from. * RecorderInCallService and RecorderThread now trim out sections of the recording where the call is in the HOLDING state. This prevents audio from a different call from being recorded while the call is on hold (due to call waiting). * RecorderThread now performs a manual contact lookup if the Android telephony framework does not provide the contact display name. This is common in conference calls and is likely a bug in AOSP. As a side effect, contact lookup now works in all supported Android versions instead of just 11+. Fixes: #284 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
conference
branch
from
ebf87ed
to
25a58fe
Compare
|
New test build: BCR-1.39.r2.g25a58fe-debugOpt.zip |
chenxiaolong
added a commit
that referenced
this pull request
Apr 12, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #284