Validate arguments when editing filename template #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of performing a test evaluation, which can miss fallback choices, we instead query the entire template AST for all variable ref nodes. For each of the nodes, we check that both the name and argument are valid. (The error messages have syntax highlighting too!) Signed-off-by: Andrew Gunnerson <[email protected]>
|
|
Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
validation
branch
from
66fa6ba
to
1c821ac
Compare
chenxiaolong
added a commit
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of performing a test evaluation, which can miss fallback choices, we instead query the entire template AST for all variable ref nodes. For each of the nodes, we check that both the name and argument are valid.
(The error messages have syntax highlighting too!)