Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Version Catalogs #381

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

PatrykMis
Copy link
Contributor

Copy link
Owner

@chenxiaolong chenxiaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple comments above, this PR looks good to me.

build.gradle.kts Show resolved Hide resolved
app/build.gradle.kts Show resolved Hide resolved
Copy link
Owner

@chenxiaolong chenxiaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about causing a conflict when I added the parcelize dependency. This PR looks good to me.

@chenxiaolong chenxiaolong merged commit fca217f into chenxiaolong:master Jul 20, 2023
1 check passed
chenxiaolong added a commit that referenced this pull request Jul 20, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
@PatrykMis
Copy link
Contributor Author

No problem.

@PatrykMis PatrykMis deleted the migrate/version-catalogs branch July 20, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants