Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ru_strings.xml #458

Merged
merged 4 commits into from
Nov 19, 2023
Merged

Update ru_strings.xml #458

merged 4 commits into from
Nov 19, 2023

Conversation

groozchique
Copy link
Contributor

• Regenerate strings with original formatting
• Improve current translation for clarity
• Fix some of the mistakes

@chenxiaolong
Copy link
Owner

chenxiaolong commented Nov 16, 2023

Thanks for the PR! Based on the error from https://github.com/chenxiaolong/BCR/actions/runs/6888626640/job/18757340198?pr=458, it looks like Android requires the few and many translations to exist for Russian:

 /home/runner/work/BCR/BCR/app/src/main/res/values-ru/strings.xml:53: Error: For locale "ru" (Russian) the following quantities should also be defined: few (e.g. "из 2 книг за 2 дня"), many (e.g. "из 5 книг за 5 дней") [MissingQuantity]
    <plurals name="retention_days">

@chenxiaolong chenxiaolong self-assigned this Nov 16, 2023
@groozchique
Copy link
Contributor Author

Thanks for the PR! Based on the error from https://github.com/chenxiaolong/BCR/actions/runs/6888626640/job/18757340198?pr=458, it looks like Android requires the few and many translations to exist for Russian:

 /home/runner/work/BCR/BCR/app/src/main/res/values-ru/strings.xml:53: Error: For locale "ru" (Russian) the following quantities should also be defined: few (e.g. "из 2 книг за 2 дня"), many (e.g. "из 5 книг за 5 дней") [MissingQuantity]
    <plurals name="retention_days">

Yeah, my bad, I missed this one out. Will fix

@chenxiaolong chenxiaolong merged commit dbce52a into chenxiaolong:master Nov 19, 2023
1 check passed
chenxiaolong added a commit that referenced this pull request Nov 19, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants