Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all dependencies #529

Merged
merged 1 commit into from
May 20, 2024
Merged

Update all dependencies #529

merged 1 commit into from
May 20, 2024

Conversation

chenxiaolong
Copy link
Owner

@chenxiaolong chenxiaolong commented Apr 16, 2024 •
edited
Loading

AGP 8.4.1 includes r8 8.4.26. r8 8.4.24 and newer include a fix for the bug where MediaCodecEncoder.encode() is miscompiled, causing a byte code verification exception to be thrown when recording a call.

Upstream bug report: https://issuetracker.google.com/issues/334275655

@chenxiaolong chenxiaolong self-assigned this Apr 16, 2024
PatrykMis
PatrykMis reviewed Apr 17, 2024
View reviewed changes
gradle/libs.versions.toml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@chenxiaolong
Copy link
Owner Author

Thanks @PatrykMis, I'll get those updated.

@chenxiaolong
Copy link
Owner Author

I'm going to hold off on merging this for a few more days because Google has identified the root cause of AGP 8.3.2 causing some code to be compiled incorrectly (https://issuetracker.google.com/issues/334275655). I'd rather not introduce the workaround of completely disabling compiler optimizations if we don't need to.

@PatrykMis
Copy link
Contributor

I'm going to hold off on merging this for a few more days because Google has identified the root cause of AGP 8.3.2 causing some code to be compiled incorrectly (https://issuetracker.google.com/issues/334275655). I'd rather not introduce the workaround of completely disabling compiler optimizations if we don't need to.

I've seen, good thorough job! So let's hope they'll release fixed AGP soon.

@NBruderman
Copy link

A fix was issued, next update should work again

@NBruderman
Copy link

@chenxiaolong AGP 8.4.0 just came out, which should include the relevant fix

@chenxiaolong
Copy link
Owner Author

chenxiaolong commented May 2, 2024 •
edited
Loading

It unfortunately does not. AGP 8.4.0 uses r8 8.4.22 and the fix for the 8.4.x branch was included only in 8.4.24+.

EDIT: This branch now pins the r8 version to 8.4.24. It seems to work fine in my initial tests.

CanerKaraca23
CanerKaraca23 reviewed May 19, 2024
View reviewed changes
gradle/libs.versions.toml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@chenxiaolong
Update all dependencies
89ecb67 
AGP 8.4.1 includes r8 8.4.26. r8 8.4.24 and newer include a fix for the
bug where MediaCodecEncoder.encode() is miscompiled, causing a byte code
verification exception to be thrown when recording a call.

Upstream bug report: https://issuetracker.google.com/issues/334275655

Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong added a commit that referenced this pull request May 20, 2024
@chenxiaolong
CHANGELOG.md: Add entry for PR #529
2d06a3d 
Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong merged commit 89ecb67 into master May 20, 2024
1 check passed
@chenxiaolong chenxiaolong deleted the deps branch May 20, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykMis PatrykMis PatrykMis left review comments

@CanerKaraca23 CanerKaraca23 CanerKaraca23 left review comments

Assignees

@chenxiaolong chenxiaolong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenxiaolong @PatrykMis @NBruderman @CanerKaraca23