Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignoring boot image checks for --prepatched #112

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

chenxiaolong
Copy link
Owner

@chenxiaolong chenxiaolong commented Jun 28, 2023

There are 3 levels of warnings:

  • Level 0: Warnings that don't affect booting
    • Mismatched id or os_version fields
  • Level 1: Warnings that may affect booting
    • Mismatched cmdline or extra_cmdline fields
    • Unexpected addition of kernel, second, recovery_dtbo, dtb, or bootconfig
  • Level 2: Warnings that are very likely to affect booting
    • All other mismatched, added, or removed fields

By default, any warning of level 1 or higher is treated as a fatal error. Each time --ignore-prepatched-compat is passed in, the permitted warning level is increased.

Fixes: #108

There are 3 levels of warnings:

* Level 0: Warnings that don't affect booting
    * Mismatched `id` or `os_version` fields
* Level 1: Warnings that may affect booting
    * Mismatched `cmdline` or `extra_cmdline` fields
    * Unexpected addition of `kernel`, `second`, `recovery_dtbo`, `dtb`,
      or `bootconfig`
* Level 2: Warnings that are very likely to affect booting
    * All other mismatched, added, or removed fields

By default, any warning of level 1 or higher is treated as a fatal
error. Each time `--ignore-prepatched-compat` is passed in, the
permitted warning level is increased.

Fixes: #108

Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong merged commit be177d0 into master Jun 29, 2023
18 checks passed
@chenxiaolong chenxiaolong deleted the ignore_prepatched branch June 29, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to ignore incompatible kernel
1 participant